fix: reject cross-repo linked issue references in mirror path (#1243)#1247
Closed
alpurkan17 wants to merge 1 commit into
Closed
fix: reject cross-repo linked issue references in mirror path (#1243)#1247alpurkan17 wants to merge 1 commit into
alpurkan17 wants to merge 1 commit into
Conversation
Collaborator
|
Duplicate of #1246 which is better scoped/implemented. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
repository_full_namefield toMirrorLinkedIssueand a cross-repo gate in_is_valid_linked_issueto reject linked issues that belong to a different repo than the PR.PR #1038 fixed this for the legacy path; this ports the same check to the mirror path. No behavior change for same-repo linked issues.
Validation
uv run ruff check— cleanuv run ruff format --check— cleanuv run pyright— 0 errors / 0 warningsuv run pytest tests/ -q— existing tests passCloses #1243